Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint migration to v9 #414

Merged
merged 88 commits into from
Feb 25, 2025
Merged

ESLint migration to v9 #414

merged 88 commits into from
Feb 25, 2025

Conversation

ezej4
Copy link
Contributor

@ezej4 ezej4 commented Apr 22, 2024

ESLint Migration to v9

This MR updates our shared ESLint configuration to align with version 9 standards.

Key Changes:

  • Updated the module system from commonjs to ES6 modules.
  • Migrated configurations to the new flat config format, following the official migration guide.
  • New compilation with vite, with this the lib will be transpiled to es6 and common-js.

This update ensures our configuration stays compatible with the latest ESLint features and best practices.

dependabot bot and others added 2 commits April 22, 2024 06:19
Bumps the eslint group with 4 updates: [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest), [eslint-plugin-react](https://github.com/jsx-eslint/eslint-plugin-react), [eslint-plugin-simple-import-sort](https://github.com/lydell/eslint-plugin-simple-import-sort) and [eslint](https://github.com/eslint/eslint).


Updates `eslint-plugin-jest` from 27.9.0 to 28.2.0
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v27.9.0...v28.2.0)

Updates `eslint-plugin-react` from 7.34.0 to 7.34.1
- [Release notes](https://github.com/jsx-eslint/eslint-plugin-react/releases)
- [Changelog](https://github.com/jsx-eslint/eslint-plugin-react/blob/v7.34.1/CHANGELOG.md)
- [Commits](jsx-eslint/eslint-plugin-react@v7.34.0...v7.34.1)

Updates `eslint-plugin-simple-import-sort` from 12.0.0 to 12.1.0
- [Changelog](https://github.com/lydell/eslint-plugin-simple-import-sort/blob/main/CHANGELOG.md)
- [Commits](lydell/eslint-plugin-simple-import-sort@v12.0.0...v12.1.0)

Updates `eslint` from 8.57.0 to 9.1.0
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
- [Commits](eslint/eslint@v8.57.0...v9.1.0)

---
updated-dependencies:
- dependency-name: eslint-plugin-jest
  dependency-type: direct:production
  update-type: version-update:semver-major
  dependency-group: eslint
- dependency-name: eslint-plugin-react
  dependency-type: direct:production
  update-type: version-update:semver-patch
  dependency-group: eslint
- dependency-name: eslint-plugin-simple-import-sort
  dependency-type: direct:production
  update-type: version-update:semver-minor
  dependency-group: eslint
- dependency-name: eslint
  dependency-type: direct:development
  update-type: version-update:semver-major
  dependency-group: eslint
...

Signed-off-by: dependabot[bot] <[email protected]>
@ezej4 ezej4 changed the title ### ESLint migration to v9 ESLint migration to v9 Apr 22, 2024
Jorge Ezequiel Fabbroni Assum added 2 commits September 9, 2024 15:26
@ezej4 ezej4 changed the title ESLint migration to v9 DRAFT: ESLint migration to v9 Sep 9, 2024
Copy link
Contributor

@pedroConsuegraMateo pedroConsuegraMateo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏🏻 👏🏻

Copy link
Contributor

@christiandebarrio christiandebarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I leave some doubts but LGTM

CHANGELOG.md Outdated
@@ -7,6 +7,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

## [3.0.0] - 2025-01-21

- Migration to [flat configs](https://eslint.org/docs/latest/use/configure/configuration-files)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Migration to [flat configs](https://eslint.org/docs/latest/use/configure/configuration-files)
- Migration to [flat configs](https://eslint.org/docs/latest/use/configure/configuration-files) making it compatible with `ESlint v9`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

dist/ts.js Outdated
@@ -0,0 +1,166 @@
import s from "path";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double-check: Is it ok that the dist folder is included in the repository (git)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, good suggest

@ezej4 ezej4 merged commit c6dbd29 into main Feb 25, 2025
12 checks passed
@ezej4 ezej4 deleted the feature/es-lint-migration-v9 branch February 25, 2025 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants